Closed Trott closed 2 years ago
Presumably a mistake I made before leaving for holiday last week. Will try to solve it tomorrow. Thanks for raising!
Hi! This was closed. Team: If this was fixed, please add phase/solved
. Otherwise, please add one of the no/*
labels.
Something which I assumed was internal was leaking and causing this error. Fixed!
Initial checklist
Affected packages and versions
remark-gfm@3.0.1
Link to runnable example
No response
Steps to reproduce
Run the example.js file in the README with the example.md in the README as input.
Expected behavior
Output should match the output shown in the README.
Actual behavior
The output for the table has
align="none"
attribute showing up. This appears to be an interoperability issue between rehypeStringify and remark-gfm (and really the underlying micromark-extension-gfm-table and hast-util-to-html modules).align="none"
is not valid, or at least that's my reading of https://developer.mozilla.org/en-US/docs/Web/HTML/Element/td#attr-align. Regardless,align
is deprecated and I think the right thing to do here is omit it (which is what the example output does).Here's the output I get:
Runtime
Node v17
Package manager
npm v7
OS
macOS
Build and bundle tools
No response