search

remarkjs / remark-github

remark plugin to link references to commits, issues, pull-requests, and users, like on GitHub
https://remark.js.org
MIT License
179 stars 22 forks source link

Fix links to longer projects, or projects with dots #15

Closed wooorm closed 5 years ago

wooorm commented 5 years ago

Previously, a bug existed because the project part of a link (bar in https://github.com/foo/bar) was checked against the algorithm for usernames instead of the algorithm for projects. Usernames are stricter (such as not allowing dots and being max 39 characters), which caused some links to not be matched (such as those with dots, or those longer than 39 characters).

Closes GH-14.

codecov-io commented 5 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         385    386    +1     
=====================================
+ Hits          385    386    +1
Impacted Files Coverage Δ
lib/util/parse-link.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5820e7d...dae7832. Read the comment docs.