search

remarkjs / remark-github

remark plugin to link references to commits, issues, pull-requests, and users, like on GitHub
https://remark.js.org
MIT License
179 stars 22 forks source link

Add support for base URL #24

Closed g12i closed 4 years ago

g12i commented 4 years ago

Solves #23

I used 2 url functions, both added in Node.js v0.1.25

I had to update all the test cases that mentioned https://codeload.github.com/, by the new rules they resolve to https://codeload.github.com/

codecov-commenter commented 4 years ago

Codecov Report

Merging #24 into main will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        20    +1     
  Lines          390       401   +11     
=========================================
+ Hits           390       401   +11
Impacted Files Coverage Δ
lib/tokenizer/hash.js 100.00% <ø> (ø)
lib/tokenizer/issue.js 100.00% <ø> (ø)
lib/index.js 100.00% <100.00%> (ø)
lib/tokenizer/mention.js 100.00% <100.00%> (ø)
lib/tokenizer/repo.js 100.00% <100.00%> (ø)
lib/util/gh.js 100.00% <100.00%> (ø)
lib/util/resolve-base-url.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eda42e5...d62c381. Read the comment docs.

g12i commented 4 years ago

Hey @wooorm! Sorry for wait, I was on holiday :). I switch to the modern API and removed unnecessary fixtures. Take a look, while I'll work on documentation.

wooorm commented 4 years ago

Oh gosh, I forgot about this WIP issue/PR when I rewrote the project. 😓 What do you think about my last comment?

g12i commented 4 years ago

Oh snap! I forgot about this as well :D. I'll try to find some time and open the new PR. It would be easier than resolving conflicts here.

wooorm commented 4 years ago

The codebase is significantly easier now, and the changes here are roughly good to go, so applying them to the new code should be possible and easier than merge conflicts!

I don’t have access to enterprise so I don‘t feel comfortable doing most of the work, but I can help you!