search

remarkjs / remark-lint-no-dead-urls

lint rule to warn when URLs are dead
https://unifiedjs.com
MIT License
78 stars 13 forks source link

Dead link is not really dead #12

Closed dialex closed 5 years ago

dialex commented 5 years ago

Your lib marks this link as dead https://vimeo.com/78912852 but it's not, as you can see by clicking it.

wooorm commented 5 years ago

@dialex Could you expand on this? Here’s some more info on creating a good, actionable, issue.

dialex commented 5 years ago

Nevermind, I created my own script to validate broken links. This lib and remark-validate-links give me too much false positives (ie. marks valid links as dead). I'm sorry, this is too unreliable for me.

NewAlexandria commented 5 years ago

Can we re-open this issue? Some vimeo links still are marked dead, when they are not. 

- Linting
✖ Linting
  README.md:212:3
  ✖  212:3  Link to https://vimeo.com/20241649 is dead  remark-lint:no-dead-urls
  ✖  213:3  Link to https://vimeo.com/9790850 is dead   remark-lint:no-dead-urls
  2 errors

@wooorm

NewAlexandria commented 5 years ago

@dialex I don't see your link validation lib. Can you post / package it, please?

davidtheclark commented 5 years ago

See https://github.com/transitive-bullshit/check-links/issues/4. check-links is the lower-level link-checking library this plugin uses. I'm sure they'd appreciate a PR, if @dialex or anybody else has ways to fix some false positives.

dialex commented 5 years ago

@NewAlexandria My bad, it was in a branch. It's merged now, this is the file. I asked a friend, it took him a couple of hours, and it works (so far no false positives) 👍

To run it: node scripts/link-validator.js docs/**/*.md (docs is my folder with markdown files)

fregante commented 5 years ago

I'm having the same issue here: https://travis-ci.org/fregante/Awesome-WebExtensions/jobs/563973345#L208

It says https://bfred.it is not working (both on Travis and my computer) but the URL loads fine

wooorm commented 5 years ago

@fregante please post an issue on the underlying project, mentioned above.