remarkjs / remark-math

remark and rehype plugins to support math
https://remark.js.org
MIT License
380 stars 57 forks source link

Update `jsdom` #94

Closed stephenlrandall closed 11 months ago

stephenlrandall commented 11 months ago

Initial checklist

Description of changes

Bumped the jsdom version to ^23.0.0 to avoid deprecation warnings from abab and domexception. Closes #93.

ChristianMurphy commented 11 months ago

Thanks @stephenlrandall! It looks like version 23 raises the minimum node version to 18 https://github.com/jsdom/jsdom/releases/tag/23.0.0 Currently we support back to version 16, so I think this would be a major version bump https://github.com/remarkjs/remark-math/blob/260521f00555789dd6171024554b6ddaffbba46d/.github/workflows/main.yml#L20

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (260521f) 100.00% compared to head (4205d96) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #94 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 15 Lines 1823 1823 ========================================= Hits 1823 1823 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stephenlrandall commented 11 months ago

Thanks @stephenlrandall! It looks like version 23 raises the minimum node version to 18 https://github.com/jsdom/jsdom/releases/tag/23.0.0 Currently we support back to version 16, so I think this would be a major version bump

https://github.com/remarkjs/remark-math/blob/260521f00555789dd6171024554b6ddaffbba46d/.github/workflows/main.yml#L20

Bumped to lts/hydrogen -- is there anything else that would need to happen for a minimum node version bump?

wooorm commented 11 months ago

I think it’s better to do update Node versions in a separate commit. Can you undo that change here? It’s indeed in different places. Don’t worry about it, I’ll take care of it!

stephenlrandall commented 11 months ago

I think it’s better to do update Node versions in a separate commit. Can you undo that change here? It’s indeed in different places. Don’t worry about it, I’ll take care of it!

Undid the change. Thanks!

github-actions[bot] commented 11 months ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

wooorm commented 11 months ago

thanks, released!