remarkjs / remark

markdown processor powered by plugins part of the @unifiedjs collective

https://remark.js.org

MIT License

7.66k stars 358 forks source link

Remove support for Node.js 12 in CLI #1007

Closed remcohaszing closed 2 years ago

remcohaszing commented 2 years ago

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes

This is a preparation for the update of unified-args in remark-cli. This also means none of the other packages in the mono repo are tested against Node 12 anymore.

wooorm commented 2 years ago

Can we do it for the CLI (and CI) only, so as not to require a major for remark/remark-parse/remark-stringify?

remcohaszing commented 2 years ago

As in, revert the changes in the other readmes?

wooorm commented 2 years ago

Yup!

codecov-commenter commented 2 years ago

Codecov Report

Merging #1007 (8d1cf14) into main (fba413a) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1007   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          901       901           
=========================================
  Hits           901       901

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fba413a...8d1cf14. Read the comment docs.

github-actions[bot] commented 2 years ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.