Feature Request: Support CBOR?

remarshal-project / remarshal

Convert between CBOR, JSON, MessagePack, TOML, and YAML

https://pypi.org/project/remarshal/

MIT License

526 stars 37 forks source link

Closed FGasper closed 4 years ago

FGasper commented 4 years ago

Would it be workable to add CBOR support to this tool?

dbohdan commented 4 years ago

What do you mean, "would it be workable"?

FGasper commented 4 years ago

I’m just requesting that CBOR be added as a 5th supported serialization.

dbohdan commented 4 years ago

I am not interested in adding CBOR myself because I don't use it. I will merge a pull request adding CBOR support if it is of similar quality to the MessagePack support (handles binaries and strings correctly in Python 3, has tests). You can look at https://github.com/dbohdan/remarshal/compare/eec355812cf7ea8382938c6e1d3c727e7ff30bad...6e57901 for reference.

FGasper commented 4 years ago

That sounds reasonable. I’ll see what I can do.

dbohdan commented 4 years ago

Added in v0.12.0.