rembo10 / headphones

Automatic music downloader for SABnzbd
GNU General Public License v3.0
3.41k stars 600 forks source link

Post Processing #118

Closed rembo10 closed 13 years ago

rembo10 commented 13 years ago

Moving files, renaming files, deleting leftovers (.sfv, .nfo, .m3u, etc.) and adding album art all work now. Still trying to figure out the best way to tag the songs but it's kinda tricky.

If you have any issues or questions, post them here.

P.S. I changed the way album art is handled so you may want to force an artist update to get all the good album art before tagging your songs :-)

MikeBuzz commented 13 years ago

Have just tested and get the following error

27-Jul-2011 10:06:24 - WARNING :: MainThread : Could not identify album: /home/xbmc/downloads/complete/Music/Take That - Progress [2010]. It may not be the intended album.

rembo10 commented 13 years ago

not really an error, per se. headphones sometimes downloads the wrong album (i.e. try searching for the xx - xx or the drums - the drums), so it runs everything against a couple checks. i'm adding some more in to make it more lenient, but on this version it does a metadata test, and an album length test. usually the metadata test works fine, as long as it's tagged with album & artist. i'm also running it against a file test, where if the filename is sort of like the file name i have in the database it will make it through.

i'm still testing it out, but if it proves to be troublesome maybe i'll just take the checks out. let me know if you continue to get that message on most of your downloads.

it's tricky though because if you download, say, florence and the machine - lungs with 12 songs, and it downloads florence and the machine - between two lungs [deluxe edition] with 20 songs, do i process it? let you specify what to do? there are just so many different releases that it's hard to figure it out.

On Jul 27, 2011, at 2:11 AM, MikeBuzz wrote:

Have just tested and get the following error

27-Jul-2011 10:06:24 - WARNING :: MainThread : Could not identify album: /home/xbmc/downloads/complete/Music/Take That - Progress [2010]. It may not be the intended album.

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1662352

MikeBuzz commented 13 years ago

would it maybe be worth tagging them in the same way as couchpotato does by creating a NFO with the details, it then reads these when come to post processing, since using this method with CP i have never had a movie renamed incorrectly

i will test with some more music and feed back any issues

rembo10 commented 13 years ago

Also expect many improvements on this over the next few days as it's something I really want to get handled

On Jul 27, 2011, at 2:11 AM, MikeBuzzreply@reply.github.com wrote:

Have just tested and get the following error

27-Jul-2011 10:06:24 - WARNING :: MainThread : Could not identify album: /home/xbmc/downloads/complete/Music/Take That - Progress [2010]. It may not be the intended album.

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1662352

rembo10 commented 13 years ago

Can you explain the nfo method? I use CouchPotato but I don't ever deal with nfo files

On Jul 27, 2011, at 2:26 AM, MikeBuzzreply@reply.github.com wrote:

would it maybe be worth tagging them in the same way as couchpotato does by creating a NFO with the details, it then reads these when come to post processing, since using this method with CP i have never had a movie renamed incorrectly

i will test with some more music and feed back any issues

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1662419

MikeBuzz commented 13 years ago

there are some details here

http://couchpotato.lighthouseapp.com/projects/56809-couch-potato/tickets/116

rembo10 commented 13 years ago

Eh, searching for music and movies are pretty different. It's the same problem RuudBurger was saying - like if movie x is labelled as movie y. The problem is identifying a download to a specific musicbrainz release. It will improve. So far with the new file based test I added, I'm 11 for 12 in terms of identifying albums correctly, and the one it couldn't identify was actually not the right album.... i'll push this version out since it seems to be doing a pretty good job

MikeBuzz commented 13 years ago

Yeah i understand i will carry on testing so far 2 download have had the same error even though the files are correct

i will test the new release once you push it out

rembo10 commented 13 years ago

yeah - i'm not sure if it's the new test, or just unlucky :-)

17 out of 18 albums correctly identified, and the one not identified was not the right album - so 18 for 18 :-). i just pushed it out

On Jul 27, 2011, at 2:55 AM, MikeBuzz wrote:

Yeah i understand i will carry on testing so far 2 download have had the same error even though the files are correct

i will test the new release once you push it out

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1662569

MikeBuzz commented 13 years ago

i have installed the new version it does not seem to be scanning the download directory now, what time period is set between scans?

MikeBuzz commented 13 years ago

just scanned now

has processed those downloads now :)

27-Jul-2011 11:08:35 - ERROR :: Thread-12 : Could not remove directory: /home/xbmc/downloads/complete/Music/Take That - The Circus [2008]. [Errno 39] Directory not empty: '/home/xbmc/downloads/complete/Music/Take That - The Circus [2008]'

27-Jul-2011 11:08:33 - INFO :: Thread-12 : Starting post-processing for: Take That - The Circus

MikeBuzz commented 13 years ago

Seems there is a issue with the way it renames when there is more than 1 cd on a album,not sure if there is a easy way round this

MikeBuzz commented 13 years ago

also the have counter does not seem to be working

rembo10 commented 13 years ago

What leftover files are there?

On Jul 27, 2011, at 3:09 AM, MikeBuzzreply@reply.github.com wrote:

just scanned now

has processed those downloads now :)

27-Jul-2011 11:08:35 - ERROR :: Thread-12 : Could not remove directory: /home/xbmc/downloads/complete/Music/Take That - The Circus [2008]. [Errno 39] Directory not empty: '/home/xbmc/downloads/complete/Music/Take That - The Circus [2008]'

27-Jul-2011 11:08:33 - INFO :: Thread-12 : Starting post-processing for: Take That - The Circus

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1662650

MikeBuzz commented 13 years ago

there was no files just 2 empty directories where they had seperated cd1 and cd2, all files had been removed

MikeBuzz commented 13 years ago

27-Jul-2011 11:28:32 - INFO :: Thread-18 : Post-processing for Green Day - 21st Century Breakdown complete

27-Jul-2011 11:28:29 - ERROR :: Thread-18 : Could not remove directory: /home/xbmc/downloads/complete/Music/Green Day - 21st Century Breakdown [2009]. [Errno 39] Directory not empty: '/home/xbmc/downloads/complete/Music/Green Day - 21st Century Breakdown [2009]'

27-Jul-2011 11:28:28 - INFO :: Thread-18 : Starting post-processing for: Green Day - 21st Century Breakdown

But the Have is still 0/18

rembo10 commented 13 years ago

It'll update on the next scan. I'll change it so it adds the values after a successful post process

I can recursively delete folders, i'm not sure why i didn't do that

On Jul 27, 2011, at 3:33 AM, MikeBuzzreply@reply.github.com wrote:

27-Jul-2011 11:28:32 - INFO :: Thread-18 : Post-processing for Green Day - 21st Century Breakdown complete

27-Jul-2011 11:28:29 - ERROR :: Thread-18 : Could not remove directory: /home/xbmc/downloads/complete/Music/Green Day - 21st Century Breakdown [2009]. [Errno 39] Directory not empty: '/home/xbmc/downloads/complete/Music/Green Day - 21st Century Breakdown [2009]'

27-Jul-2011 11:28:28 - INFO :: Thread-18 : Starting post-processing for: Green Day - 21st Century Breakdown

But the Have is still 0/18

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1662784

DeMolT commented 13 years ago

I don't get an error, but post processing doesn't seem to be able to process a certain album and keeps on retrying.

27-Jul-2011 22:10:11 - INFO :: Thread-25 : Starting post-processing for: Dire Straits - Communiqué

Looks like the é is the trouble maker in this part.

It should be: Dire Straits - Communiqué

Great job so far! :)

rembo10 commented 13 years ago

How weird. I tested post processing with foreign characters (Bjork, Sigur Ros) and it worked fine. Does the album show up correctly in Headphones?

On Jul 27, 2011, at 1:19 PM, DeMolT wrote:

I don't get an error, but post processing doesn't seem to be able to process a certain album and keeps on retrying.

27-Jul-2011 22:10:11 - INFO :: Thread-25 : Starting post-processing for: Dire Straits - Communiqué

Looks like the é is the trouble maker in this part.

It should be: Dire Straits - Communiqué

Great job so far! :)

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1667205

DeMolT commented 13 years ago

Yes, it shows up correctly and also downloads without any problems. I just keep it running, but still starts new post-processing threads.

27-Jul-2011 22:25:10 - INFO :: Thread-28 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:20:10 - INFO :: Thread-27 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:15:10 - INFO :: Thread-26 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:10:11 - INFO :: Thread-25 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:05:10 - INFO :: Thread-24 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:00:11 - INFO :: Thread-23 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:55:11 - INFO :: Thread-22 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:50:10 - INFO :: Thread-21 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:45:10 - INFO :: Thread-20 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:40:10 - INFO :: Thread-19 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:35:10 - INFO :: Thread-18 : Starting post-processing for: Dire Straits - Communiqué

rembo10 commented 13 years ago

I'll figure it out - it's correctly identifying the album, but then getting stuck somewhere in the middle.

On Jul 27, 2011, at 1:30 PM, DeMolT wrote:

Yes, it shows up correctly and also downloads without any problems. I just keep it running, but still starts new post-processing threads.

27-Jul-2011 22:25:10 - INFO :: Thread-28 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:20:10 - INFO :: Thread-27 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:15:10 - INFO :: Thread-26 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:10:11 - INFO :: Thread-25 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:05:10 - INFO :: Thread-24 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 22:00:11 - INFO :: Thread-23 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:55:11 - INFO :: Thread-22 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:50:10 - INFO :: Thread-21 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:45:10 - INFO :: Thread-20 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:40:10 - INFO :: Thread-19 : Starting post-processing for: Dire Straits - Communiqué

27-Jul-2011 21:35:10 - INFO :: Thread-18 : Starting post-processing for: Dire Straits - Communiqué

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1667287

rembo10 commented 13 years ago

@ DeMolT - try the latest version, at least I can see where it's going wrong. What OS are you on? It worked fine on OSX

@ MikeBuzz - the newest version recursively removes directories, so you shouldn't get that 'unable to remove directory' error anymore. I was worried about doing that because I didn't want to delete like, someone's whole hard drive if they accidentally put in the wrong path but since I'm controlling the album path now this won't ever happen :-)

DeMolT commented 13 years ago

I'm running it on Windows 7 Ultimate x64, I updated headphones just now but it appears that it got stuck or something.

In the logs the latest log was 10,5 hours ago:

28-Jul-2011 06:54:04 - INFO :: Thread-99 : Now adding/updating album: 2002-01-24: A State of Trance 32

28-Jul-2011 06:53:56 - INFO :: Thread-99 : Now adding/updating album: 2002-01-17: A State of Trance 31

28-Jul-2011 06:53:48 - INFO :: Thread-99 : Now adding/updating album: 2002-01-10: A State of Trance 30

28-Jul-2011 06:53:40 - INFO :: Thread-99 : Now adding/updating album: 2002-01-03: A State of Trance 29

28-Jul-2011 06:53:32 - INFO :: Thread-99 : Now adding/updating album: 2001-12-27: A State of Trance 28: Top 20 of 2001

28-Jul-2011 06:53:24 - INFO :: Thread-99 : Now adding/updating album: 2001-12-20: A State of Trance 27

28-Jul-2011 06:53:16 - INFO :: Thread-99 : Now adding/updating album: 2001-12-13: A State of Trance 26

28-Jul-2011 06:53:08 - INFO :: Thread-99 : Now adding/updating album: 2001-12-07: A State of Trance 25

28-Jul-2011 06:53:01 - INFO :: Thread-99 : Now adding/updating album: 2001-11-29: A State of Trance 24: Passion, Coalville, UK

28-Jul-2011 06:52:53 - INFO :: Thread-99 : Now adding/updating album: 2001-11-22: A State of Trance 23: Golden at Stoke-On-Trent, UK

28-Jul-2011 06:52:45 - INFO :: Thread-99 : Now adding/updating album: 2001-11-15: A State of Trance 22

28-Jul-2011 06:52:38 - INFO :: Thread-99 : Now adding/updating album: 2001-11-08: A State of Trance 21

28-Jul-2011 06:52:31 - INFO :: Thread-99 : Now adding/updating album: 2001-11-01: A State of Trance 20: Club Scanners, Dordrecht, The Netherlands

28-Jul-2011 06:52:23 - INFO :: Thread-99 : Now adding/updating album: 2001-10-25: A State of Trance 19

28-Jul-2011 06:52:15 - INFO :: Thread-99 : Now adding/updating album: 2001-10-18: A State of Trance 18

28-Jul-2011 06:52:07 - INFO :: Thread-99 : Now adding/updating album: 2001-10-11: A State of Trance 17

28-Jul-2011 06:51:58 - INFO :: Thread-99 : Now adding/updating album: 2001-10-05: A State of Trance 16

28-Jul-2011 06:51:50 - INFO :: Thread-99 : Now adding/updating album: 2001-09-28: A State of Trance 15

28-Jul-2011 06:51:42 - INFO :: Thread-99 : Now adding/updating album: 2001-09-21: A State of Trance 14

28-Jul-2011 06:51:34 - INFO :: Thread-99 : Now adding/updating album: 2001-09-14: A State of Trance 13: Guest Vincent Van Tongeren

28-Jul-2011 06:51:26 - INFO :: Thread-99 : Now adding/updating album: 2001-09-07: A State of Trance 12

28-Jul-2011 06:51:18 - INFO :: Thread-99 : Now adding/updating album: 2001-08-24: A State of Trance 11

28-Jul-2011 06:51:10 - INFO :: Thread-99 : Now adding/updating album: 2001-08-17: A State of Trance 10

28-Jul-2011 06:51:01 - INFO :: Thread-99 : Now adding/updating album: 2001-08-10: A State of Trance 9

28-Jul-2011 06:50:53 - INFO :: Thread-99 : Now adding/updating album: 2001-08-03: A State of Trance 8

28-Jul-2011 06:50:45 - INFO :: Thread-99 : Now adding/updating album: 2001-07-27: A State of Trance 7

28-Jul-2011 06:50:37 - INFO :: Thread-99 : Now adding/updating album: 2001-07-20: A State of Trance 6

28-Jul-2011 06:50:29 - INFO :: Thread-99 : Now adding/updating album: 2001-06-29: A State of Trance 5

28-Jul-2011 06:50:21 - INFO :: Thread-99 : Now adding/updating album: 2001-06-22: A State of Trance 4

28-Jul-2011 06:50:13 - INFO :: Thread-99 : Now adding/updating album: 2001-06-15: A State of Trance 3

28-Jul-2011 06:50:10 - INFO :: Thread-135 : Starting post-processing for: Dire Straits - Communiqué

Is there a way to reset the threads or something?

brannon-bowden commented 13 years ago

So Headphones updated and shows the albums were downloaded, but the albums still show 0/xx. Although I just realized all of my albums show 0/xx currently.

premiso commented 13 years ago

When the files get moved / directory gets created, it seems to use 0777, can we change the permissions to be 0755 on the folders? That would be great, or at least have an option in the Settings to set the mask for the end result folders.

Also it seemed to have removed my SAB Music Download folder after processing, is there a way for it to not remove that folder (more of just a personal preference for that one).

Is there a plan for a Post-Processing script to be written for SAB integration (much like Sickbeard) I would prefer this over disk checks. Thanks. Great app!

rembo10 commented 13 years ago

@DeMoIT - most of your log shows that it's updating albums (with similar names): http://musicbrainz.org/artist/477b8c0c-c5fc-4ad2-b5b2-191f0bf2a9df?page=2 - but yeah, it might be getting stuck. Restart headphones, and check the logs for when it tries to post process the Dire Straits album. It seems like it's not even adding album art (that's step 1) :-/

@Sytanek - the 'have' albums now update after post-processing. Update available in a few

@ premiso - it uses 0755 by default, but maybe i need to force it with a chmod. What OS are you on? chmod would only change permissions on the end result folder, so if you had your setup like: artist/album/tracks, only the album folder would be 0755 - only because i have no control over how you set up your folder structure (if you just had something like: artist-album/tracks, the artist-album folder would be 0755)

Also @ premiso - yeah I messed up, the next update will keep your sab music folder :-)

DeMolT commented 13 years ago

@rembo10 I know that it is showing albums updating, but those were logs that were 10 hours old and I just checked but nothing changed, First things I did was restart Headphones even though I just updated to the latest version ;)

I'm thinking about deleting my DB but if you want to explore / fix this issue I will leave it be for now and help with that, just let me know :)

premiso commented 13 years ago

@rembo10 Understood, I am on Ubuntu Maverick 10.10. I fixed that in the code using my own methods (See the Have thread I posted). Thanks for the timely response at any rate.

rembo10 commented 13 years ago

@ DeMoIT - PM me - I'll try to debug it

Most other issues fixed in the latest release: have count gets updated (but the index won't reflect this until it runs the artist update due to the way it's now handled), empty directories recursively removed, sab music folder won't get deleted, retried albums will be processed, etc.

acewatson commented 13 years ago

My post processing seems to be renaming the files correctly. It is not creating the artist folder though. I left the settings for advanced settings as default.

rembo10 commented 13 years ago

Do ypu have anything set in the "destination directory" in settings? That might be it

On Jul 28, 2011, at 8:56 PM, acewatsonreply@reply.github.com wrote:

My post processing seems to be renaming the files correctly. It is not creating the artist folder though. I left the settings for advanced settings as default.

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1678625

DeMolT commented 13 years ago

What do you want me to send you in an DM?

rembo10 commented 13 years ago

Just to try to debug the post-processing stuff. Did the new version fix it? Do other albums with special characters also throw it off? Might be a windows thing, i'll have to test it

DeMolT commented 13 years ago

I updates to the latest version, but according to the logs nothing is changing it is still hangin' on the latest addition from almost 2 days ago.

It didn't make the folder for the Comminuque album. Because it isn't postprocessing or doing anything at all (besides downloading), I can't try other albums.

DeMolT commented 13 years ago

fyi When HP finds an artist / album and sends it to sab, this isn't registered in the logs anymore. Looks like the logs and postprocessing got stuck or something.

DeMolT commented 13 years ago

I killed the python session and restarted python/headphones, now it is logging and postprocessing again; stupid me that I didn't think of that earlier...

I updated to the latest version you just commited, and it is doing more now. It starts Post-processing but hangs on Writing metadata: 29-Jul-2011 12:23:00 - INFO :: Thread-13 : Writing metadata

29-Jul-2011 12:23:00 - INFO :: Thread-13 : Cleaning up files

29-Jul-2011 12:23:00 - INFO :: Thread-13 : Adding album art

29-Jul-2011 12:23:00 - INFO :: Thread-13 : Starting post-processing for: Dire Straits - Communiqué

29-Jul-2011 12:18:00 - INFO :: Thread-12 : Writing metadata

29-Jul-2011 12:18:00 - INFO :: Thread-12 : Cleaning up files

29-Jul-2011 12:18:00 - INFO :: Thread-12 : Adding album art

29-Jul-2011 12:18:00 - INFO :: Thread-12 : Starting post-processing for: Dire Straits - Communiqué

DeMolT commented 13 years ago

I maybe found the problem, it is writing metadata for the first 2 songs. But the third song is being a pain in the ass.

The difference is that that filename has a space behind the title: Dire Straits - 03 - Where Do You Think You're Going .mp3

I'll test it now.

Update: Hmm, I changed the filename and took away the extra space. The postprocessoring restarted but still hangs on that same file. Strange enough it has the space again...Looks like Headphones puts the extra space or something :S

update 2:...it was a double space, now trying it again without these spaces.

ghost commented 13 years ago

I am having similar issues on unraid:

29-Jul-2011 07:53:59 - INFO :: Thread-206 : Starting post-processing for: [Albums name] 29-Jul-2011 07:53:59 - INFO :: Thread-206 : Adding album art 29-Jul-2011 07:53:59 - INFO :: Thread-206 : Cleaning up files 29-Jul-2011 07:53:59 - INFO :: Thread-206 : Writing metadata 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Starting post-processing for: [Albums name] 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Adding album art 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Cleaning up files 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Writing metadata 29-Jul-2011 08:03:59 - INFO :: Thread-208 : Starting post-processing for: [Albums name] 29-Jul-2011 08:03:59 - INFO :: Thread-208 : Adding album art 29-Jul-2011 08:04:16 - INFO :: Thread-208 : Cleaning up files 29-Jul-2011 08:04:16 - INFO :: Thread-208 : Writing metadata 29-Jul-2011 08:08:59 - INFO :: Thread-209 : Starting post-processing for: [Albums name] 29-Jul-2011 08:08:59 - INFO :: Thread-209 : Adding album art 29-Jul-2011 08:12:09 - INFO :: Thread-209 : Cleaning up files 29-Jul-2011 08:12:09 - INFO :: Thread-209 : Writing metadata

Is there any way to manually run the postprocessing? Some albums doesn't seem to be post processed

rembo10 commented 13 years ago

Jlguerrer- are you on Win7 too? I'll get a fix up tomorrow but in the meantime you may want to move that folder out of your downloads folder so it stops trying to process

On Jul 29, 2011, at 4:03 AM, jlguerrerreply@reply.github.com wrote:

I am having similar issues on unraid:

29-Jul-2011 07:53:59 - INFO :: Thread-206 : Starting post-processing for: Miguel Bosé - Cardio 29-Jul-2011 07:53:59 - INFO :: Thread-206 : Adding album art 29-Jul-2011 07:53:59 - INFO :: Thread-206 : Cleaning up files 29-Jul-2011 07:53:59 - INFO :: Thread-206 : Writing metadata 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Starting post-processing for: Miguel Bosé - Cardio 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Adding album art 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Cleaning up files 29-Jul-2011 07:58:59 - INFO :: Thread-207 : Writing metadata 29-Jul-2011 08:03:59 - INFO :: Thread-208 : Starting post-processing for: Miguel Bosé - Cardio 29-Jul-2011 08:03:59 - INFO :: Thread-208 : Adding album art 29-Jul-2011 08:04:16 - INFO :: Thread-208 : Cleaning up files 29-Jul-2011 08:04:16 - INFO :: Thread-208 : Writing metadata 29-Jul-2011 08:08:59 - INFO :: Thread-209 : Starting post-processing for: Miguel Bosé - Cardio 29-Jul-2011 08:08:59 - INFO :: Thread-209 : Adding album art 29-Jul-2011 08:12:09 - INFO :: Thread-209 : Cleaning up files 29-Jul-2011 08:12:09 - INFO :: Thread-209 : Writing metadata

Is there any way to manually run the postprocessing? Some albums doesn't seem to be post processed

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1680407

DeMolT commented 13 years ago

Looks like post-processing isn't working, I tried some different albums and they have the same thing as jlguerrer has.

I'll let it be for now, looking forward to your update ;)

ghost commented 13 years ago

Hi rembo10, i am on unRAID 5 (Slackware 13.1). I have moved the folder out of the downloaded folders and it has stopped trying to process it but still doesn't process other albums.

Thank you for you help. Your program is amazing.

rembo10 commented 13 years ago

It actually looks like its writing the metadata fine, the problem is the renaming.

I can't seem to find the common thread though of what it will rename and what it won't. It's definitely the filename that I'm passing in so it's fixable

On Jul 29, 2011, at 3:37 AM, DeMolTreply@reply.github.com wrote:

I maybe found the problem, it is writing metadata for the first 2 songs. But the third song is being a pain in the ass.

The difference is that that filename has a space behind the title: Dire Straits - 03 - Where Do You Think You're Going .mp3

I'll test it now.

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1680303

rembo10 commented 13 years ago

It's the question marks that it tries to add into the filenames :-/

At least that's what breaks it in win7

On Jul 29, 2011, at 5:25 AM, jlguerrerreply@reply.github.com wrote:

Hi rembo10, i am on unRAID 5 (Slackware 13.1). I have moved the folder out of the downloaded folders and it has stopped trying to process it but still doest process other albums.

Thank you for you help. Your program is amazing.

Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/118#issuecomment-1680784

DeMolT commented 13 years ago

The problem seems to be fixed, it's post-processing like it should do :)

One small thing I got was that one of the files didn't rename, again the song with the double spaces in the end of the filename: Dire Straits - 03 - Where Do You Think You're Going .mp3

But that could be the problem of the name.

Great job mate!

rembo10 commented 13 years ago

DeMoIT - it's not the spaces, Headphones was trying to add a '?' at the end: "Where Do You Think You're Going?" which threw back an error on windows and i guess unraid (but not on osx so I didn't notice it). The new version replaces ?'s with _'s

Thanks for testing!

DeMolT commented 13 years ago

Ah, I didn't think about that!.

You're welcome, being able to help for such a good cost is my pleasure ;)

ghost commented 13 years ago

I still have problems with the new version of the post processor. It fails on non ASCII characters.

31-Jul-2011 01:32:29 - ERROR :: Thread-181 : Error renaming file: /mnt/cache/Music/[track file]. Error: ('ascii', u'/mnt/cache/Music/[track file]', 99, 100, 'ordinal not in range(128)')

rembo10 commented 13 years ago

@ jlguerrer - did you see the last couple posts here: Ascii error when scanning current music? It may help since it's a mounted share looks like

DeMolT commented 13 years ago

I have a problem with one album of Green Day: 1,039/Smoothed Out Slappy Hours

The foldername after downloading (temp): Green Day - 1,039+Smoothed Out Slappy Hours [1991]

This one doesn't want to post process, see the log: http://img641.imageshack.us/img641/1782/errorhp.jpg

rembo10 commented 13 years ago

Ugh - ok, if an album can't be found in the db, it tries to get the release group id from musicbrainz to check against. I think the + sign is throwing off the search. Let me figure out a good way to work around this since SAB is renaming '/' to '+'