search

rembo10 / headphones

Automatic music downloader for SABnzbd
GNU General Public License v3.0
3.36k stars 600 forks source link

REQUEST: deal with unprocessed albums automaticly #251

Open xburchartz opened 12 years ago

xburchartz commented 12 years ago

Sometimes an album cannot be processed because the downloaded album contains incorrect files. The album cannot be identified in that case.

Question: do you both search for ID3 tags and file names for trying to postproces? If it's really impossible to identify the album, I'd like Headphones to delete the unprocessed album and automaticly search/download another nzb.

rembo10 commented 12 years ago

Yeah i was thinking about something like this - I just wasn't sure if people wanted it to delete an unprocessed album or what. Maybe keep it unless a verifiable version can be found, then delete the unprocessed folder.

It checks id3 tags first (for artist + album match), then tries filenames (song titles), then album duration

Swixxy commented 12 years ago

I think some people might like to keep the unprocessed album for manual checking, however the log doesn't say what unprocessed means so perhaps adding "Please add this album into the correct space manually" to the log file would get people doing it, as i wasn't sure what the unprocessed was reffering to until reading this.

However an option in settings to delete all unprocessed albums and find a new album on failure to process would allow both these options?

Or as you suggest, try and find a new album and if none is found, don't delete it otherwise delete it

mgaulton commented 10 years ago

I vote for having both options. Rename and leave or delete. I prefer delete as I've had issues with lots of folders. That being said, I had an issue with the utorrent code renaming my download folder so delete would be bad in that scenario :)

toofewacres commented 10 years ago

I would prefer leaving them, but not renaming.. I use torrents only and the renaming screws up seeding. I watch the history screen and know what has been processed and what hasn't. But HP would have to stop looking for that particular item to process once it been determined it needs to dealt with manually.

mgaulton commented 10 years ago

So sounds like leave alone, rename and delete are the 3 options to meet all the possible scenarios.

NoobyNull commented 10 years ago

Leave alone Rename - current Delete Move to new directory.
And/or a combination. For seeders, copy to directory for pp, and leave original for seeding.

rembo10 commented 10 years ago

The way it's handled now was written like 3 years ago now.... just as a quick solution. It definitely needs to be updated.

I think another option is to try to find a new version (assume that the one downloaded is incorrect)

On Jul 9, 2014, at 4:16 PM, MatthewYax notifications@github.com wrote:

Leave alone Rename - current Delete Move to new directory.

And/or a combination. For seeders, copy to directory for pp, and leave original for seeding.

— Reply to this email directly or view it on GitHub.

jiBYo commented 7 years ago

Is this still open to discussion?

Currently any torrent that can not be processed gets renamed to "whatever (Unprocessed)", this screws up all my seeding and gives me a lot of hit n runs... This is bad. Can a file be put in the folder instead so it knows? And maybe have a separate page for unprocessed files within the web page? That way the folder can be left unchanged and my private trackers still love me :)

I love this app but this is one problem that is letting me down, mainly because I leave home for work for so long that when I get back I am hit with all these hnrs...

rembo10 commented 7 years ago

Do you have the 'copy for torrents' option checked? If it's still renaming those that needs to be fixed

On Dec 26, 2016 2:29 AM, "jiBYo" notifications@github.com wrote:

Is this still open to discussion?

Currently any torrent that can not be processed gets renamed to "whatever (Unprocessed)", this screws up all my seeding and gives me a lot of hit n runs... This is bad. Can a file be put in the folder instead so it knows? And maybe have a separate page for unprocessed files within the web page? That way the folder can be left unchanged and my private trackers still love me :)

I love this app but this is one problem that is letting me down, mainly because I leave home for work for so long that when I get back I am hit with all these hnrs...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rembo10/headphones/issues/251#issuecomment-269150004, or mute the thread https://github.com/notifications/unsubscribe-auth/AAw69Qx0isLQndyirIQ0vUqP6hS_lEO7ks5rLyaigaJpZM4CLjoi .

jiBYo commented 7 years ago

Yes, I double checked all options availible...

AdeHub commented 7 years ago

@jiBYo it probably shouldn't be setting to Unprocessed but there is a hidden config option to stop this happening, have a look here

oakbrad commented 6 years ago

I would appreciate this option as well, I have all of my downloading/seeding automated but would like to have the Unprocessed moved elsewhere so I can deal with them manually

I see where it is called in postprocessor.py, it seems straightforward to add. I am very new to python/git, will see if I can figure it out