rembo10 / headphones

Automatic music downloader for SABnzbd
GNU General Public License v3.0
3.35k stars 604 forks source link

Python 3.12 support - headphones does not run because of deprecated ImpImporter #3330

Closed jason1987d closed 1 month ago

jason1987d commented 6 months ago

Upon launching /opt/headphones/Headphones.py with a system python 3.12. It is my understanding 3.12 removed ImpImporter.

raceback (most recent call last):
  File "/opt/headphones/Headphones.py", line 27, in <module>
    from headphones import webstart, logger
  File "/opt/headphones/headphones/__init__.py", line 27, in <module>
    import cherrypy
  File "/opt/headphones/lib/cherrypy/__init__.py", line 60, in <module>
    import pkg_resources
  File "/opt/headphones/lib/pkg_resources/__init__.py", line 2172, in <module>
    register_finder(pkgutil.ImpImporter, find_on_path)
                    ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?
ottoking8912 commented 6 months ago

Having the same problem, headphones won't run with python3.12. Please fix.

rembo10 commented 5 months ago

Hey, would you guys mind trying out the python312 branch? If that's too tricky I can get it into develop, but I think there are just too many changes to get it into master right now. Sorry also for the delay

jason1987d commented 5 months ago

Hey, would you guys mind trying out the python312 branch? If that's too tricky I can get it into develop, but I think there are just too many changes to get it into master right now. Sorry also for the delay

Yes, I ran from this branch and it runs on linux with python 3.12 installation. Selecting multiple albums or the 'all' checkbox from an artist for 'Wanted' appears to not work 'You didn't select any albums', not sure if there's already an issue for this. Still testing other features.

uniquePWD commented 1 month ago

Hey, would you guys mind trying out the python312 branch? If that's too tricky I can get it into develop, but I think there are just too many changes to get it into master right now. Sorry also for the delay

Any news on getting this fix into main?

rembo10 commented 1 month ago

It's there now.... I'll cut a release...