rembo10 / headphones

Automatic music downloader for SABnzbd
GNU General Public License v3.0
3.37k stars 601 forks source link

MarkAlbums error 500 : helpers is undefined #3344

Open wschikowske opened 1 month ago

wschikowske commented 1 month ago

Hi after updating to latest headphones i got the following error in front console on MarkAlbums method

iam using headphone on docker (waxou/headphones)

Results to modal error : "You didn't select any albums" tested with firefox & chrome

payload :


ArtistID: b71e9993-4a2c-4b6d-87b1-dc496ab105a5
action: Wanted
0bead08b-36a7-472c-8811-1fdf00ef693c: on
7fc02492-4379-4965-b981-4e5890200733: on
28ab118a-6445-4f1a-bf7c-0a9af40977a2: on
a699cfd4-b2c7-411a-9aa3-390b6fdb58dd: on
fe9ee12e-bae8-4d2c-9180-b27e4c221361: on
500 Internal Server Error
The server encountered an unexpected condition which prevented it from fulfilling the request.

Traceback (most recent call last):
  File "/app/headphones/lib/cherrypy/_cprequest.py", line 659, in respond
    self._do_respond(path_info)
  File "/app/headphones/lib/cherrypy/_cprequest.py", line 718, in _do_respond
    response.body = self.handler()
  File "/app/headphones/lib/cherrypy/lib/encoding.py", line 223, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/app/headphones/lib/cherrypy/_cpdispatch.py", line 54, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/app/headphones/headphones/webserve.py", line 405, in markAlbums
    searcher.searchforalbum(mbid, new=False)
  File "/app/headphones/headphones/searcher.py", line 257, in searchforalbum
    do_sorted_search(album, new, losslessOnly)
  File "/app/headphones/headphones/searcher.py", line 328, in do_sorted_search
    results = searchSoulseek(album, new, losslessOnly, albumlength)
  File "/app/headphones/headphones/searcher.py", line 1956, in searchSoulseek
    cleanalbum = unidecode(helpers.replace_all(album['AlbumTitle'], replacements)).strip()
NameError: name 'helpers' is not defined

Edit : happens when losing folder reference ? i scanned artist again & now it works for this artist... for some others still got the problem

switching back to linuxserver/headphones (so get previous release -38commits) & no more issues

AdeHub commented 1 month ago

Can you try the develop branch

double-v commented 1 month ago

ok it works, ty. btw seems to only be a front issue. saw wanted requests in docker logs