rembo10 / headphones

Automatic music downloader for SABnzbd
GNU General Public License v3.0
3.41k stars 600 forks source link

Extras "Other + Spokenword" are ignored #695

Closed w00dst0ck closed 10 years ago

w00dst0ck commented 12 years ago

Headphones will get the realeases tagged as "Album" and "Album + Live". But releases tagged as "Other + Spokenword" are ignored.

Example: http://musicbrainz.org/artist/e028fab5-39ae-4ed9-b8c2-c4344d88b171

rembo10 commented 12 years ago

will add this in in the next update

w00dst0ck commented 12 years ago

Thanx!

rembo10 commented 12 years ago

When searching for spoke word, use audio book category? On Jun 19, 2012 7:57 PM, "w00dst0ck" < reply@reply.github.com> wrote:

Thanx!


Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/695#issuecomment-6426255

w00dst0ck commented 12 years ago

I don't understand what you mean.

I search for the artist and enable extras to scrap the missing releases with the type: "Othe + Spokenword" http://musicbrainz.org/release/22d4c39a-663f-4e5a-af33-42748365ac69/tags

I've tested your enhanced mb.py but not all releases are shown in headphones.

Regards, w00dst0ck

rembo10 commented 12 years ago

Sorry - i meant that when searching providers for other (audio books and spoken word) does it make sense to use the audio books category? Thats how I've done it - seems to be working well. Its in the develop branch On Jun 26, 2012 3:14 PM, "w00dst0ck" < reply@reply.github.com> wrote:

I don't understand what you mean.

I search for the artist and enable extras to scrap the missing releases with the type: "Othe + Spokenword" http://musicbrainz.org/release/22d4c39a-663f-4e5a-af33-42748365ac69/tags

I've tested your enhanced mb.py but not all releases are shown in headphones.

Regards, w00dst0ck


Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/695#issuecomment-6571350

w00dst0ck commented 12 years ago

I've tested the develop branch and I still get only 29 albums form over 154 albums at musicbrainz. http://musicbrainz.org/artist/e028fab5-39ae-4ed9-b8c2-c4344d88b171/releases?page=1

BTW, thanx for your work!

rembo10 commented 12 years ago

Maybe its filtering out casettes or something? I'll check the code - its in master now btw On Jun 27, 2012 2:58 PM, "w00dst0ck" < reply@reply.github.com> wrote:

I've tested the develop branch and I still get only 29 albums form over 154 albums at musicbrainz.

http://musicbrainz.org/artist/e028fab5-39ae-4ed9-b8c2-c4344d88b171/releases?page=1

BTW, thanx for your work!


Reply to this email directly or view it on GitHub: https://github.com/rembo10/headphones/issues/695#issuecomment-6598746

w00dst0ck commented 12 years ago

Checked the updated master branch but the result is the same. Only 35 of over 150 releases are visible in headphones.

rembo10 commented 12 years ago

There must be some filter that's not letting the other albums get through. Is there anything in common about the ones its not adding, e.g. non-official, etc.

w00dst0ck commented 12 years ago

Currently it only gets the following other albums.

1979 Die drei ??? Volume 1: und der Super-Papagei Spokenword 1979 Die drei ??? Volume 2: und der Phantomsee Spokenword 1979 Die drei ??? Volume 3: und der Karpatenhund Spokenword 1979 Die drei ??? Volume 4: und die schwarze Katze Spokenword 1979 Die drei ??? Volume 5: und der Fluch des Rubins Spokenword 1979 Die drei ??? Volume 6: und der sprechende Totenkopf Spokenword 1979 Die drei ??? Volume 7: und der unheimliche Drache Spokenword 1979 Die drei ??? Volume 8: und der grüne Geist Spokenword 1979 Die drei ??? Volume 9: und die rätselhaften Bilder Spokenword 1980 Die drei ??? Volume 10: und die flüsternde Mumie Spokenword 1980 Die drei ??? Volume 11: und das Gespensterschloss Spokenword 1980 Die drei ??? Volume 12: und der seltsame Wecker Spokenword 1980 Die drei ??? Volume 13: und der lachende Schatten Spokenword 1980 Die drei ??? Volume 14: und das Bergmonster Spokenword 1980 Die drei ??? Volume 15: und der rasende Löwe Spokenword 1980 Die drei ??? Volume 16: und der Zauberspiegel Spokenword 1980 Die drei ??? Volume 17: und die gefährliche Erbschaft Spokenword 1980 Die drei ??? Volume 18: und die Geisterinsel Spokenword 1980 Die drei ??? Volume 19: und der Teufelsberg Spokenword 1980 Die drei ??? Volume 20: und die flammende Spur Spokenword 1980 Die drei ??? Volume 21: und der tanzende Teufel Spokenword 1981 Die drei ??? Volume 22: und der verschwundene Schatz Spokenword 1981 Die drei ??? Volume 23: und das Aztekenschwert Spokenword 1981 Die drei ??? Volume 24: und die silberne Spinne Spokenword 1981 Die drei ??? Volume 25: und die singende Schlange Spokenword

But there are more then 150 other albums at http://musicbrainz.org/artist/e028fab5-39ae-4ed9-b8c2-c4344d88b171.

I can't see anything that's different between a working one (http://musicbrainz.org/release-group/70e72219-9adf-37bc-8c39-72be9354ff16) and a NON working one (http://musicbrainz.org/release-group/61fddc66-de01-3987-a53c-c07660a5ee13)

rembo10 commented 12 years ago

Turns out there is a hardcoded limit of 100 release groups when doing the 'getArtist' command. But it doesn't explain why you'd only get 25. When you try to refresh the artist, does it say "Updating for: Die drei complete" at the end of the 25?

w00dst0ck commented 12 years ago

I've removed the extras and fetched them again. Headphones once again get only 25 albums.

Timestamp Level Message 2012-11-05 15:11:08 INFO Updating complete for: Die drei ??? 2012-11-05 15:11:08 INFO Seeing if we need album art for: Die drei ??? 2012-11-05 15:11:08 INFO Seeing if we need album art for Die drei ??? Volume 24: und die silberne Spinne 2012-11-05 15:11:07 INFO Now adding/updating: Die drei ??? Volume 24: und die silberne Spinne 2012-11-05 15:11:06 INFO Seeing if we need album art for Die drei ??? Volume 10: und die flüsternde Mumie 2012-11-05 15:11:05 INFO Now adding/updating: Die drei ??? Volume 10: und die flüsternde Mumie

rembo10 commented 10 years ago

Closing this in favor of #1488