search

rembound / Arena-Helper

A plugin for Hearthstone Deck Tracker that helps drafting Hearthstone arena decks.
http://rembound.com
222 stars 71 forks source link

Only detecting class and first card choice, stops detecting afterwards #101

Closed ghost closed 8 years ago

ghost commented 8 years ago

First 3 cards are Stampeding Kodo, Muster for Battle and Master Jouster, but next 3 cards were not detected. http://i.imgur.com/s9kdKgj.jpg

rembound commented 8 years ago

Thanks for the report. Should be fixed in next version.

rembound commented 8 years ago

Made is more reliable in the new version.

nicolasdalsass commented 8 years ago

I think what happens is it trigger the next card detection to fast when a card is selected, and it's still able to see the old cards. Tbh, I think a small manual "redetect" button (e.g where the grey square for manual hero picking is) would do wonder :) Still a great plugin !

rembound commented 8 years ago

Yeah, the old cards are getting re-detected. I've modified it so that when it detects the same cards, it needs to detect these cards multiple times in a row. When different cards are detected, it just continues as normal.

nicolasdalsass commented 8 years ago

Yeah, I saw the fix, but I don't think it's working as intended since the triple loop still seems to happen too fast, and the 3 detections can end before the new cards appear. I guess a Thread.sleep(3 seconds) between the loop could work too, but I don't know the language to PR it :/

rembound commented 8 years ago

Will add a timed delay with a maximum for the next update.

Edit: Removed the test build, download the latest release.