Tierlist updated with Scholomance cards.

rembound / Arena-Helper

A plugin for Hearthstone Deck Tracker that helps drafting Hearthstone arena decks.

http://rembound.com

222 stars 71 forks source link

Closed CharString closed 4 years ago

CharString commented 4 years ago

I have updated the tierlist.

Are the CardId's and names always different from the official xml in the Lightforge api?

scottismyname commented 4 years ago

This doesn't really change much......the code gets the json data from the website and then changes it a bunch (only retaining pertinent information).

There is another pull request that automatically updates this, but it was not implemented. Would be nice to have this working.

CharString commented 4 years ago

I know. I just saw it was stale. Fixed it locally (with a small bug handling 0 value cards I see) and thought I'd share it.

rembound commented 4 years ago

Thanks for the effort! Card ids are from https://github.com/HearthSim/hsdata Bug with 0 value cards?

CharString commented 4 years ago

Bug with 0 value cards?

My conversion script didn't differentiate between "0" and "" values. I fixed it since.