rembound / Arena-Helper

A plugin for Hearthstone Deck Tracker that helps drafting Hearthstone arena decks.
http://rembound.com
222 stars 71 forks source link

Arena Helper mistakenly detect Demon Hunter as Paladin #168

Closed minhngoc25a closed 4 years ago

minhngoc25a commented 4 years ago

image

After I started an Arena run, the plugin had mistakenly detected the Illidan hero as Paladin.

swilkins1337 commented 4 years ago

I noticed myself, but I didn't take a screenshot at the time, otherwise I might've reported it. Anyway, I did some digging, and it looks like HDT returns "DemonHunter" and Arena Helper is expecting "Demon Hunter". You could fix Plugin.cs:245, but I'm pretty sure that would cause it to render as "DemonHunter" in the UI. Maybe the bug should be kicked upstream to HDT?

Edit: They might not want to change it in HDT because it could break other plugins. Perhaps add a displayname field to herolist.

rembound commented 4 years ago

Thanks for the bug report. Added a fix in v0.9.5, but couldn't test it properly yet.