remche / terraform-openstack-rke2

Deploy Kubernetes on OpenStack with RKE2
Mozilla Public License 2.0
48 stars 29 forks source link

Rke2 config change #25

Closed powellchristoph closed 2 years ago

powellchristoph commented 2 years ago

Move the file function out of the module. This will allow templated file contents to be passed rather than a straight yaml file. Change rke2_config_file to rke2_config.

# old
rke2_config_file = "server.yaml"

# new
rke2_config      = file("server.yaml")
rke2_config      = templatefile("${path.module}/files/controlplane.tpl", somevars)
remche commented 2 years ago

@powellchristoph thanks for the PR, it makes sense to me. Do you have any relevant usecase to add in examples directory ?

powellchristoph commented 2 years ago

I updated one of the existing examples.

remche commented 2 years ago

I saw this, I will merge ASAP, thanks again !

remche commented 2 years ago

Thanks for this contribution that makes this module better ! :partying_face: