search

remche / terraform-openstack-rke2

Deploy Kubernetes on OpenStack with RKE2
Mozilla Public License 2.0
48 stars 29 forks source link

Add support for existing networks #54

Open kompiz opened 1 year ago

kompiz commented 1 year ago

This PR is for adding support to existing networks. This is done by checking the value of the boolean assign_floating_ip - if it's true new networks be created, if false existing networks will be used instead.

I don't have access to a provider for testing if everything works as intended when the var assign_floating_ip is true. Could someone else try this?

If there is any code that is unclear or badly written, don't hesitate to let me know - I appreciate learning how to improve.

remche commented 1 year ago

@kompiz thanks for your work in this PR. I will review/test asap.

kompiz commented 1 year ago

Is the code very messy? 😅 Let me know if I can help explain what's going on.

remche commented 1 year ago

I didn't have time to dive into it but it's very important to me not to introduce breaking changes (i.e. examples/minimal test). I will be really happy to merge the PR once it's ok. Thanks again for you work on this features !

kompiz commented 1 year ago

Absolutely. There are a few places I'm slightly worried about, I can't test them myself as my provider is a bit different. I'll put comments on them later today.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

pratik705 commented 1 year ago

Hello @kompiz @remche

Is this feature ready for the use? I have a use case where I would like to use existing provider network in the openstack environment.

remche commented 1 year ago

@pratik705 this PR is not ready to merge now because it would break existing deployment.

I bet you can use the PR branch for your module source and it will use just work though.