search

remcoboerma / jbrout

Automatically exported from code.google.com/p/jbrout
0 stars 0 forks source link

XMP:Rating is not supported (read/write) #206

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Rate the picture with Shotwell (or another application which writes 
XMP-xmp:Rating, but not the EXIF Rating/RatingPercent tags)
2. Import the rated picture into jBrout.
3. Inspect the rating of the picture in jBrout.

What is the expected output? What do you see instead?

The rating defined in Shotwell is expected to be available in jBrout, whereas 
it is not.

What version of the product are you using? On what operating system?

I am using JBrout 0.3.340, right from the repository (not svn) in Ubuntu 12.04

Please provide any additional information below.

In fact, Shotwell reads and updates only the XMP Rating tag, whereas jBrout 
reads and updates only the EXIF Rating/RatingPercent tags. (support for XMP 
write only was added in the original patch for rating, bug #95 released in 
r314, but I suspect it was removed by bug #129 in r335)

==> Please find attached a patch to address this issue. The logic is summarized 
hereafter:

- During jBrout Import/Refresh, when reading the rating from the file, 
  + look at the XMP tag first, and update the EXIF tags if needed
  + then look at the EXIF tags, and update the XMP tag if needed
- During jBrout rating, when writing the rating to the file,
  + udpate the XMP tag and the EXIF tags

Please note that JBrout.conf["synchronizeXmp"] has not been used.

Original issue reported on code.google.com by julien.d...@gmail.com on 4 Aug 2012 at 11:29

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by r...@wallace.gen.nz on 4 Oct 2012 at 7:28

GoogleCodeExporter commented 9 years ago

Original comment by matej.c...@gmail.com on 12 Aug 2013 at 10:35

GoogleCodeExporter commented 9 years ago 
Created a new branch in the git repo visible on 
https://gitorious.org/jbrout/jbrout/source/XMP-rating-206

Original comment by matej.c...@gmail.com on 22 Sep 2013 at 6:28

GoogleCodeExporter commented 9 years ago 
Fixed in r365

Original comment by matej.c...@gmail.com on 6 Dec 2013 at 1:09