search

remcohaszing / pywakeonlan

A small python module for wake on lan.
https://pywakeonlan.readthedocs.io
MIT License
286 stars 70 forks source link

Cleanup mac formatting and packet creation logic #13

Closed DavidPratt512 closed 4 years ago

DavidPratt512 commented 4 years ago

Simplify logic of formatting mac addresses (may want to make a separate function) and changed the creation of magic packets to use a list comprehension.

remcohaszing commented 4 years ago

Thank you for your contributions!

I haven’t touched this project for a while. I migrated the project to GitHub actions and Poetry. Could you please rebase so I can verify GitHub actions is setup correctly?

Your changes look fine, so if not, I’ll merge your changes soon anyway.

DavidPratt512 commented 4 years ago

To be honest, I'm still new to git, but I believe I rebased correctly with master.

remcohaszing commented 4 years ago

Sorry for the delay. I wanted to test this on a physical device.

I think something went wrong rebasing, but when checking it locally, all changes seem to be alright.

Thanks for the cleanups! And also for rebasing, this helped me validate GitHub actions are setup correctly :smile: