remcohaszing / pywakeonlan

A small python module for wake on lan.
https://pywakeonlan.readthedocs.io
MIT License
281 stars 68 forks source link

Update actions to support new python versions and remove EOL versions or soon to be EOL versions #18

Closed L1ghtn1ng closed 3 years ago

L1ghtn1ng commented 3 years ago

I have also added a dependabot file that will update dependencies and also keep the github actions up to date as well.

Also added "CodeQL" action

codecov[bot] commented 3 years ago

Codecov Report

Merging #18 (9e75a4c) into master (4b1d80f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files           1        1           
  Lines          30       30           
  Branches        5        5           
=======================================
  Hits           26       26           
  Misses          2        2           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b1d80f...9e75a4c. Read the comment docs.

remcohaszing commented 3 years ago

Thank you for your interest, but I prefer sticking to CLI tools that can be run locally as well. IMO the autobuild tries to be too magical..

Dependabot updatres seem nice, but pywakeonlan doesn’t have any dependencies and I’m not interested in keeping my dev-dependencies up-to-date.

This PR did spark my interest to update this package a bit, so thanks for that. :)

L1ghtn1ng commented 3 years ago

The dependabot will keep actions up to date as well as any dependencies as you was using an out dated setup-python action that was causing the ci to fail. No problem for sparking your interest and what got me was when I updated my app-server OS things broke until I pulled from git and thought I would contribute back to something I have been using for years😊


From: Remco Haszing @.> Sent: Sunday, April 4, 2021 8:24:39 PM To: remcohaszing/pywakeonlan @.> Cc: J.Townsend @.>; Author @.> Subject: Re: [remcohaszing/pywakeonlan] Update actions to support new python versions and remove EOL versions or soon to be EOL versions (#18)

Thank you for your interest, but I prefer sticking to CLI tools that can be run locally as well. IMO the autobuild tries to be too magical..

Dependabot updatres seem nice, but pywakeonlan doesn’t have any dependencies and I’m not interested in keeping my dev-dependencies up-to-date.

This PR did spark my interest to update this package a bit, so thanks for that. :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/remcohaszing/pywakeonlan/pull/18#issuecomment-813086691, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3V2QTP5T5VZQ3MJOXB3RLTHC4HPANCNFSM4ZLGPPTQ.