remcohaszing / pywakeonlan

A small python module for wake on lan.
https://pywakeonlan.readthedocs.io
MIT License
281 stars 68 forks source link

Allowed to use mac address in xxxx.xxxx.xxxx format. #24

Closed vladislavru closed 1 year ago

vladislavru commented 2 years ago

Added a check for the correctness of mac address symbols

vladislavru commented 2 years ago

Thanks! I haven’t really seen this format though. Do you have a practical example of where this mac address format is used?

Yes, sure. Any Cisco switch:

switch01>show mac address-table Mac Address Table

Vlan Mac Address Type Ports


All 0100.0ccc.cccc STATIC CPU All 0100.0ccc.cccd STATIC CPU All 0180.c200.0000 STATIC CPU 1 0015.2993.e478 DYNAMIC Gi1/0/1 1 0015.2993.d520 DYNAMIC Gi1/0/1 1 0015.3093.addf DYNAMIC Gi1/0/1

codecov[bot] commented 1 year ago

Codecov Report

Merging #24 (ebe3998) into main (aeab03f) will decrease coverage by 4.14%. The diff coverage is 75.00%.

:exclamation: Current head ebe3998 differs from pull request most recent head 6484ae8. Consider uploading reports for the commit 6484ae8 to get more accurate results

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   93.33%   89.18%   -4.15%     
==========================================
  Files           1        1              
  Lines          30       37       +7     
  Branches        5        7       +2     
==========================================
+ Hits           28       33       +5     
- Misses          1        3       +2     
  Partials        1        1              
Impacted Files Coverage Δ
wakeonlan.py 89.18% <75.00%> (-4.15%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

remcohaszing commented 1 year ago

Thanks! Sorry for the delay! I will release this soon.

remcohaszing commented 1 year ago

This has been released in version 3.0.0.