search

remcohaszing / pywakeonlan

A small python module for wake on lan.
https://pywakeonlan.readthedocs.io
MIT License
281 stars 68 forks source link

Allow specifying ipv6 addresses #26

Closed alimg closed 9 months ago

alimg commented 2 years ago

If your ISP supports ipv6 like mine, chances are you are already getting a persistent address already without having to pay for a static ipv4 address. This commit enables us to send magic packets to ipv6 targets.

infalmo commented 9 months ago

Hi, can this be merged? Would appreciate ipv6 support, thanks!

remcohaszing commented 9 months ago

Sure! Could you rebase this, process the feedback, and provide a new PR?

Ideally could you also verify this works? I’m inclined to believe it does, but I can’t test it myself.

alimg commented 9 months ago

Sorry for long radio silence, I forgot I had this PR for a while. I address the comments and cleaned up a bit further. Hope you liked it better now.

Unfortunately my ISP decided not to give me an IPv6 address these days. Any help is appreciated to test if this works.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aa98922) 94.11% compared to head (f583983) 95.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## ========================================== + Coverage 94.11% 95.34% +1.23% ========================================== Files 1 1 Lines 34 43 +9 Branches 7 8 +1 ========================================== + Hits 32 41 +9 Misses 1 1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

remcohaszing commented 9 months ago

Could you fix CI? I tried, but I’m not allowed to push to your fork.

remcohaszing commented 9 months ago

Released in version 3.1.0 :tada: