Improve use of Divan - Githubissues

remi-dupre / pinix

Progress In Nix - Pacman inspired frontend for Nix

GNU Lesser General Public License v3.0

28 stars 4 forks source link

Closed nvzqz closed 4 months ago

nvzqz commented 4 months ago

usize implements IntoCounter<Counter = ItemsCount>, allowing Vec::len() to be used directly.
The loaded example does not change between benchmarks, so there's no need to pass it via Bencher::with_inputs().
The parsed values are now black_box-ed to prevent them from being optimized out.
Removed comment from copy+pasted docs example.

remi-dupre commented 4 months ago

Hi!

Thanks for the fix, and also for the efforts on Divan. I've never been a fan of Criterion so I'm happy to see alternatives taking shape :+1: