Implicit-session configs break tmux session name

[bitprophet]

Scenario:

• Using tmux solely to create new windows-with-splits; no configs have explicit session settings in them.
  • I manually manage my sessions (e.g. one for work, one for personal/OSS, etc).
• Executing tmux pollutes my existing session name, calling it e.g. teamocil- (I think tmux is truncating the name, possible)
• This is because teamocil is auto-generating a unique session name when sessions aren't given (in lib/teamocil/layout/session.rb::Session#initialize).
• There's no way to disable this behavior.

This seems to regress whatever was done to fix #5.

I regret I have no time to submit a PR for this, partly as I'm not sure what the preferred fix would be.

Suspect best is for implicitly created sessions to skip the automatic name generation - folks using the session are by definition not creating new sessions and do not need the collision-avoidance random name.

[bitprophet]

For reference this is what I ended up doing on my end: https://github.com/bitprophet/teamocil/compare/master...no-session-renames-plz

• When implicit session is created, it just gets the default/nil name, and no rename-session ends up executed. Yay!
• When explicit sessions are created without a name, they still get the randomized name written out.
• Explicit sessions with explicit names also continue to work.

Happy to PR w/ specs (sometime) if I get a +1 on this approach.

[remi]

I’m going to close the issue because most of the codebase has since changed. Feel free to reopen it if you feel this is an issue in Teamocil 1.0+.