remiX- / QualityCompany

MIT License
4 stars 0 forks source link

GeneralImprovements mod bugs some labels #11

Closed NilaierMusic closed 5 months ago

NilaierMusic commented 6 months ago

With options such as PickupInOrder, RearrangeOnDrop and TwoHandedInSlotOne set to true from GeneralImprovements, QualityCompany's labels either fail to display on some items, or stay there, even if items have been dropped already.

image Lethal_Company_aiVBHsBR6Y

remiX- commented 6 months ago

Hey @NilaierMusic

Can you see if enabling InventoryForceUpdateAllSlotsOnDiscard fixes this?

NilaierMusic commented 6 months ago

Setting ForceUpdateAllSlotsOnDiscard to true seems to fix the label ghosting issue, but it still doesn't fix other issues like shotguns not having any labels when you first pick them up in your ship after reloading the game or UI elements shifting to weird places after hopping through different saves. Lethal_Company_5k5gYBuC07

JustinHZAP commented 6 months ago

With options such as PickupInOrder, RearrangeOnDrop and TwoHandedInSlotOne set to true from GeneralImprovements, QualityCompany's labels either fail to display on some items, or stay there, even if items have been dropped already.

The problem here is that GeneralImprovements does not use base game "methods" of moving items around on the HUD, they are doing it in a sort of "behind the scenes" way. This makes their mod more unfriendly to base game hooks. However we try to accommodate these type of things in QualityCompany.

Setting ForceUpdateAllSlotsOnDiscard to true seems to fix the label ghosting issue, but it still doesn't fix other issues like shotguns not having any labels when you first pick them up in your ship after reloading the game or UI elements shifting to weird places after hopping through different saves.

There is a delay configuration, QualityCompany waits for HUD modifications to be applied before initializing which may cause this issue if you try to pick up items before this delay, the inventory may be initialized unexpectedly. We will look into improving this as we develop the mod.

remiX- commented 6 months ago

@NilaierMusic It's a bit unfortunate that GeneralImprovements shuts off all other monitor texts other than its' own. Any chance anyone has logged this on their end?

image

Edit #1:

GI's "TwoHandledInSlotOne" seems to work fine as picking up this painting shows the correct value in slot one. But without QC's InventoryForceUpdateAllSlotsOnDiscard, others go out of sync but that is the purpose of this config as I'm sure it works on PickUp too.

image

remiX- commented 5 months ago

Closing this for now as there have not been any more updates and not being able to reproduce on our side.

Please re-open or log a new issue if the issue arises again 😄