search

remiberthoz / anki-periodic-table-memory-pegs

Periodic Table flashcard deck for Ankl
https://ankiweb.net/shared/info/490209917
MIT License
50 stars 5 forks source link

NightMode Styling #123

Closed ohare93 closed 4 years ago

ohare93 commented 4 years ago

Anki 2.1.20 recently added a native NightMode setting in the config. It works by automatically inveryting most colors, however it seems to not work for specifically set rgba values, tho it provides a ".nightMode" override for the css to handle things like that.

This PR contains the styling necessary to have all things be visible in that mode. I tweeked the alpha variables a bit to what looks good to me personally, feel free to change it of course 👍

remiberthoz commented 4 years ago

Hey!

Thank you for this pull request. Night mode is a feature other people have been asking and because I don't use it myself, I haven't put a lot of attention to it...

If I may suggest, I would change the card's background from pure back to a dark grey like rgba(33, 33, 33, 1). Similarly, the card's headers (css box_title) currently have a light colour, I would rather transform that to a darker shade so that the text can be in white. The original "day mode" theme was based on Google's Material Design colour palette, it would be nice to ride along the trend and pick colours from there!

If you don't mind doing it, I'll wait for new commits on the pull request.

Thank you again for the implementation.

ohare93 commented 4 years ago

Alright here you go, how does this look?

image

I applied the grey background, and changed the colour of box_title, as requested. Box_Title cannot be too dark though as most of the images use black as their line colour of choice (see the above pic of Protactinium as an example). It's dark enough to allow for white text though, so I think it's good enough 👍

remiberthoz commented 4 years ago

Wow that's nice! Thank you very much! I'll of merge and publish over the weekend.

remiberthoz commented 4 years ago

Hey! Sorry for the delay. The PR is now merged and changes are reflected in version 2.3.0, released to AnkiWeb!

Thank you :smiley: