search

remiberthoz / anki-periodic-table-memory-pegs

Periodic Table flashcard deck for Ankl
https://ankiweb.net/shared/info/490209917
MIT License
51 stars 5 forks source link

Proposal: Use Poetry to manage dependencies #139

Open sebbdk opened 10 months ago

sebbdk commented 10 months ago

I was pulling the repo down to see how it worked and i could not spot any dependency management. :)

Poetry is quite nice for managing dependencies when working in a team, it creates a localized .venv folder per project and makes sure that everyone is using the same versions of libraries. Similar to how NPM works for nodejs.

To use it install poetry and run "poetry install" to add all the dependencies to the project specific .venv folder and thats it. :)

https://python-poetry.org/

remiberthoz commented 10 months ago

Hi,

Thank you for this PR. Indeed there is no dependency management and I already struggle with that problem myself when I tried to recompile the package after many months.

I won't have time to edit or test the PR before a week, but I see no reasons not to merge. Would you agree to fill more poetry metadata? I am especially keen to have the list of authors matching the contributions on GitHub, and the license set to MIT.

Thanks! 🎉