search

remiberthoz / anki-periodic-table-memory-pegs

Periodic Table flashcard deck for Ankl
https://ankiweb.net/shared/info/490209917
MIT License
50 stars 5 forks source link

Added memory pegs for Bohrium and Nihonium, but missing images #3

Closed Lykos closed 4 years ago

Lykos commented 4 years ago

The cards are still missing images and I am not 100% sure the guids are correct.

I don't know how 100% guids work, it says in the documentation it's a random string of length 10. So I took the union of all characters appearing in other guids and created a string of length 10 based on those characters. Not sure whether this is correct.

It seems you are pretty efficient at creating those images while it would take me forever to figure out how to do it.

If this is no help at all, feel free to reject. If you like the memory pegs, take it and complete it.

remiberthoz commented 4 years ago

Hey, thank you for contributing :tada: !

You did well with the guids, as you said they only have to be a random, unique, string of characters. As for the pictures, I create them as 32x32 pixels gif files in gimp. I can illustrate Bohrium and Niohnium to match the pegs you proposed.

I will be very happy to merge the changes. For consistency of the git history, may I ask you to:

Lykos commented 4 years ago

Ok, thanks. I am at work now, will do when I get home.

Lykos commented 4 years ago

Done

remiberthoz commented 4 years ago

Perfect, thank you !

remiberthoz commented 4 years ago

Changes in this PR close #110 and #116

Lykos commented 4 years ago

I have memory pegs for the remaining ones, too, but they are all in German.

They work super nice in German. E.g. Bohrium sounds like "drill" and 7 sounds like "use a sieve", so 107 is actually that someone drills and the dust from that gets put into a sieve. "Hassium" sounds like "Haselnuss" which is "hazelnut" or "hassen" which is "to hate" and "8" sounds like "attention", so there are some obvious things of paying attention about the hazelnut hater.

On Tue, Jan 14, 2020 at 9:06 PM Rémi Berthoz notifications@github.com wrote:

Changes in this PR close #110 https://github.com/remiberthoz/anki-periodic-table-memory-pegs/issues/110 and #116 https://github.com/remiberthoz/anki-periodic-table-memory-pegs/issues/116

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/remiberthoz/anki-periodic-table-memory-pegs/pull/3?email_source=notifications&email_token=AABZTUO5RIEYT5F63ZDHCGTQ5YLMXA5CNFSM4KGKJS42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI56BMY#issuecomment-574349491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZTUKNHVJ6VRZ2PV4D2W3Q5YLMXANCNFSM4KGKJS4Q .

remiberthoz commented 4 years ago

The pull request is now merged into the master branch, and released with version v2.2.0! Thanks for contributing!