search

remicres / otbtf

Deep learning with otb (mirror of https://forgemia.inra.fr/orfeo-toolbox/otbtf)
Apache License 2.0
161 stars 39 forks source link

Remove the dirty hack #99

Open eclipse95 opened 4 months ago

eclipse95 commented 4 months ago

Hi, I see that there is a "dirty hack" in the Dockerfile. I see that your module uses C++17 and OTB doesn't fully support it. This PR set C++ 17 only for your module in CMakefile. So, it removed the dirty hack in the Dockerfile.

I have also added Python dependencies in the setup.py. I have split the PR in 3 distinct commits if you prefer cherry-pick it.

remicres commented 4 months ago

Thanks a lot @eclipse95 ! I'll check how the CI behaves with the proposed changes this week

remicres commented 4 months ago

Unfortunately the CI does not pass at the docker build stage.

Did you succeed to build the docker image with the proposed changes? If yes, could you provide the ARGs used? (OTB version, etc)

Thanks

eclipse95 commented 4 months ago

Hi, OK, I didn't check in the same context. I built Debian packages OTB+OTBTF (to use it on Colab). I take OTB from Debian upstream repository (OTB version 8.1.2). I didn't use "super build", but the default used by Debian with some tweaks, so some features (such as OTB_USE_6S) are not built.

I will check with the Dockerfile provided in the repository.