search

remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
221 stars 24 forks source link

wont let me build a branch name with "@" in it #16

Open dalyons opened 8 years ago

dalyons commented 8 years ago

& I wanna.

ejholmes commented 8 years ago

Apparently this is a limitation of docker tags, which must match [a-z0-9]+(?:[._-][a-z0-9]+)*. We could disable the branch tag if it doesn't match this regex, but then we'll lose the caching advantage. Might be better to just error out with a better error message.

ejholmes commented 8 years ago

Another option would be to just use a hash of the branch name for the cache tag (but still push the branch for convenience, if it matches that regex).