search

remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
221 stars 24 forks source link

add support for private docker registry #17

Open barkco opened 8 years ago

barkco commented 8 years ago

Would be nice to allow docker hub credentials (optional) in order to push containers to private registries.

ejholmes commented 8 years ago

I may have misunderstood your original question. Are you referring to pushing images to a private repo on the official docker registry? If so, you just need to pass a .dockercfg formatted string to the DockerCfg parameter

e.g.

{"https://index.docker.io/v1/":{"auth":"<base64 auth>","email":"<email>"}}
Luzifer commented 8 years ago

+1 for supporting private registries. (Not private repos on official registry)

Currently github.com/Luzifer/myrepo would be pushed to DockerHub Luzifer/myrepo and there is no real chance to use registry.luzifer.io/myrepo instead (except string-manipulation in the building container).

(Sorry for highjacking the thread)

wyaeld commented 8 years ago

@ejholmes any further comments? For people doing a lot of private work, particularly in AWS regions where the docker registry isn't nearby, having Conveyer able to support pushing/pulling from other registries would be really useful. So far this is the most impressive builder I've seen.

phobologic commented 8 years ago

Just a heads up: @ejholmes is in the process of moving, so probably won't be super responsive for a bit.

ejholmes commented 8 years ago

Hey @wyaeld. I probably won't be adding support for it myself until we start moving away from the official Docker registry to Amazon's registry, but if you'd like to take a crack at it, an MVP version would be pretty straightforward. Maybe:

  1. Add a new --docker.registry flag.
  2. Pass this down to the docker builder as a REGISTRY environment variable.
  3. Prefix the docker push/pull commands in the build script to include the registry.