remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
221 stars 24 forks source link

support for github enterprise #43

Open cordoval opened 8 years ago

cordoval commented 8 years ago

i think this change should be easy, i am myself trying to find the spot but just asking here too

UPDATE: https://github.com/google/go-github/blob/master/github/github.go#L27 and on NewClient method https://github.com/google/go-github/blob/master/github/github.go#L132 we need to change there https://github.com/remind101/conveyor/blob/master/builder/github.go#L22 here is another place that needs to be changed

cordoval commented 8 years ago

another set of places that need to be updated

https://github.com/remind101/conveyor/blob/master/builder/docker/bin/build#L60 and https://github.com/remind101/conveyor/blob/master/builder/docker/bin/build#L73

cordoval commented 8 years ago

@ejholmes any comments/guidance before trying to attempt a PR here?

cordoval commented 8 years ago

trying to address in https://github.com/remind101/conveyor/pull/50