search

remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
221 stars 24 forks source link

cloudformation stack template prompts for dockercfg #44

Closed cordoval closed 8 years ago

cordoval commented 8 years ago

I have the latest docker tools on my laptop and therefore i have a ~/.docker/config.json file with different format (https://github.com/docker-java/docker-java/issues/316) than the dockerfcfg that perhaps this template is expecting, will this work with the config.json contents i pasted in there?

cordoval commented 8 years ago

confirmed WARNING: Error loading config file:Invalid auth configuration file

ubuntu@ip-10-0-0-86:~$ docker --version
Docker version 1.7.1, build 786b29d

I guess docker version 1.7.1 does still use the dockercfg format

https://github.com/docker/compose/issues/1590

just realized the template is out of date really!

cordoval commented 8 years ago

i needed to reference this commend i made https://github.com/remind101/conveyor/pull/18#issuecomment-167866233

i think we should lock to version 1.7.0 tbh cc @ejholmes for now before moving into the .dockercfg -> .docker/config.json, i am having a nightmare

We can change here backwards but i rather move forward https://github.com/remind101/conveyor/blob/master/roles/docker/defaults/main.yml#L1