search

remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
220 stars 24 forks source link

because docker is now 1.7.1 on default ami #45

Closed cordoval closed 8 years ago

cordoval commented 8 years ago

solves this https://github.com/remind101/conveyor/issues/44

ejholmes commented 8 years ago

Hmm, doesn't this need support in the docker builder as well? Right now, it tries to copy /var/run/conveyor/.dockercfg, which wouldn't exist with this change.

cordoval commented 8 years ago

true, i will change it, any other place i have missed? cc @ejholmes

cordoval commented 8 years ago

updated @ejholmes

cordoval commented 8 years ago

rebased @ejholmes , what are the ways you try things on your end? i am curious, i sometimes try stuff and it does not work

ejholmes commented 8 years ago

Testing the builder is a little tricky because it currently relies on pulling from a github repo and pushing to a docker repo. You have to run make bootstrap in the builder/docker then upload the ssh key to your github account, then run make test. I want to get this running in CI so it's at least tested there.

cordoval commented 8 years ago

rebased @ejholmes i will test in a bit by hand, can you please also do the same?

cordoval commented 8 years ago

this one is hard to test because the image that is spawn by this is not pushed to dockerhub and is not the remind101/conveyor image. For instance i have even tried to build the ami with packer when i switch to cordoval/conveyor but without luck

ejholmes commented 8 years ago

This looks good to me. I'll merge and build a new version of remind101/conveyor-builder.

cordoval commented 8 years ago

Thanks man, it feels good! :+1: