search

remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
221 stars 24 forks source link

can we try catch the calls to github status change? #49

Closed cordoval closed 8 years ago

cordoval commented 8 years ago

i am getting this error, it is just because github has some weird problems with updating status https://github.com/travis-ci/travis-ci/issues/1283 

2015/12/30 18:20:11 Starting build: id=7a16a452-2475-49d2-96b3-66d2731d4ce0 repository=cordoval/convey-test branch=master sha=a4371fb913c8366bb2bf95b622b60d15081731c2
reporting err: POST https://api.github.com/repos/cordoval/convey-test/statuses/a4371fb913c8366bb2bf95b622b60d15081731c2: 422 Validation Failed [{Resource:Status Field:target_url Code:custom}]
2015/12/30 18:20:11 POST https://api.github.com/repos/cordoval/convey-test/statuses/a4371fb913c8366b

I wonder if we can wrap the calls with try catch equivalent to avoid this

cordoval commented 8 years ago

I am wondering if it won't work with personal github tokens? how did you create your token to pass via cli?

cordoval commented 8 years ago

bump @ejholmes any hints please? thanks

cordoval commented 8 years ago

closing as i ran into another problem after appending the missing http for the url. What is curious is the url is asked upfront and if one is deploying with terraform it is not known apriori. That is of course another problem.

cordoval commented 8 years ago

Problem i have ran into now is:

2016/01/04 20:35:13 Starting build: id=27f80fdd-bd28-4f32-8c35-54e1756921c9 repository=cordoval/convey-test branch=master sha=94caa1f63a1b1c13c6720d683ec4b1b387006fac
reporting err: container returned a non-zero exit code: 1
cordoval commented 8 years ago

it freaking works now, ha ha, was just not building the right dockerfile