search

remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
221 stars 24 forks source link

Update Godeps #60

Closed dlackty closed 7 years ago

dlackty commented 8 years ago

Recently I started trying this project and found:

  1. go-uuid packages was moved from Google Code to GitHub
  2. honeybadger v0.0.1 also depended on that packages, so I updated it to newer v0.0.2.
ejholmes commented 8 years ago

Hey @dlackty, thanks for this! We've been trying to move our projects away from godep and instead use the new Go 1.6 vendoring, which I think would solve the problem you probably ran into (I'm guessing godep restore fails?).

To manage deps, we've been using govendor and migrating the Godeps folder with govendor migrate.

dlackty commented 8 years ago

Hey @ejholmes I've added a new commit to use govendor instead. Could you please have a look?

ejholmes commented 8 years ago

I think CircleCI is still using Go 1.5.3, so we'll need to set GO15VENDOREXPERIMENT=1 in the environment.

dlackty commented 8 years ago

Both updated, and CI became green as well.

dlackty commented 8 years ago

this should also close #61

bronislav commented 8 years ago

@ejholmes Any updates on this?

ejholmes commented 7 years ago

I pulled this in with https://github.com/remind101/conveyor/commit/ad2254bbcfb644f40a6923b1cd4fcbd04235b48a, so master is build-able without godep.