remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
221 stars 24 forks source link

fix vendored hookshot #74

Closed sumeet closed 7 years ago

sumeet commented 7 years ago

idk how this got in there

ejholmes commented 7 years ago

👍 on a side note, this has made me realize that Go structs for unmarshalling third part responses should be as small as possible. The field that GH broke wasn't even used by Conveyor, but it breaks because we try to unmarshal it. If the field is present, then it just gets ignored by encoding/json.

Either that, or third party's shouldn't break backwards compat =\