remind101 / conveyor

A fast build system for Docker images.
http://engineering.remind.com/introducing-conveyor/
BSD 2-Clause "Simplified" License
220 stars 24 forks source link

Switch to GitHub Apps #76

Closed ejholmes closed 6 years ago

ejholmes commented 6 years ago

Fixes https://github.com/remind101/conveyor/issues/65

GitHub Apps has been GA for a while, so this switches Conveyor over to using a GitHub app to make authenticated requests to github (creating github commit statuses, and resolving branches to shas).

From a security perspective, this is a lot better since it provides repo level isolation, which normal access tokens do not. From a UX standpoint, it's also better because it simplifies webhook installation, and makes commit statuses come from the Conveyor app itself.

TODO