search

remind101 / empire

A PaaS built on top of Amazon EC2 Container Service (ECS)
BSD 2-Clause "Simplified" License
2.69k stars 158 forks source link

Ability to disable Route53/ELB integration via flag #723

Open Flygsand opened 8 years ago

Flygsand commented 8 years ago

Like a conditional around this for this. -routing.disable?

We have our own service discovery and load balancing mechanisms in place, but enjoy Empire's Herokuish workflow.

Flygsand commented 8 years ago

FWIW, work has begun here: wowgroup/empire@63a4c0a4. Rather than -routing.disable, there's -scheduler=ECS (default: =ECS_LoadBalanced). Other scheduler implementations could fit in here, of course. I haven't really found anything within Empire that assumes DNS records and ELBs always will be created, other than that client commands pertaining to e.g. management of domains and certs would become no-ops. Perhaps it could be useful to report "operation not implemented by this backend" to the client in these instances, or some such.

ejholmes commented 8 years ago

Awesome! :+1: on a --scheduler flag. Yeah, we built the ECS implementation of the scheduler with being able to remove the ELB/Route53 aspect easily so this should be fine.