search

remind101 / slashdeploy

GitHub Deployments for Slack
https://slashdeploy.io
BSD 2-Clause "Simplified" License
153 stars 20 forks source link

SlashDeploy /teams page. #108

Closed russellballestrini closed 6 years ago

russellballestrini commented 6 years ago

Proof of concept of SlashDeploy /teams page.

Also ads a user interface for logging in and out.

Refactors a single way of getting User object from Github ID

    new file:   app/controllers/teams_controller.rb
    modified:   app/github/deployment_status_event.rb
    modified:   app/models/user.rb
    modified:   app/views/layouts/application.html.erb
    new file:   app/views/teams/index.html.erb
    modified:   config/routes.rb
    modified:   spec/features/commands_spec.rb

slashdeploy-teams

russellballestrini commented 6 years ago

@ejholmes I think the test is failing because the User exists but no github_account is attached. Is this a condition we need to deal with?

russellballestrini commented 6 years ago

@ejholmes could you review this again? I'm still planning on iterating further in another PR but I'm thinking releasing often / frequently could be fun.

Do you know why this test is failing?

russellballestrini commented 6 years ago

Ok @ejholmes could you take another pass? I think this is ready and I'm excited to merge!