Our slash commands all expect a User object with an associated GithubAccount and SlackAccount.
We created a regression when we changed how we implemented
User#username such that it no longer raises MissingGitHubAccount.
As a result, the super class of our slash commands no longer triggered
this exception if a User object did not have an associated
GithubAccount.
As a result we never send the user a login link.
To fix this regression I make the superclass call User#github_account
method which triggers MissingGitHubAccount so that it can be rescued by
our authentication routines.
Our slash commands all expect a User object with an associated GithubAccount and SlackAccount.
We created a regression when we changed how we implemented
User#usernamesuch that it no longer raises MissingGitHubAccount.As a result, the super class of our slash commands no longer triggered this exception if a User object did not have an associated GithubAccount.
As a result we never send the user a login link.
To fix this regression I make the superclass call User#github_account method which triggers MissingGitHubAccount so that it can be rescued by our authentication routines.