search

remind101 / slashdeploy

GitHub Deployments for Slack
https://slashdeploy.io
BSD 2-Clause "Simplified" License
153 stars 20 forks source link

Oops, logic / assumption error #129

Closed russellballestrini closed 6 years ago

russellballestrini commented 6 years ago

Only try to unlock a user's currently active locks.

modified:   app/models/user.rb
modified:   spec/models/user_spec.rb
russellballestrini commented 6 years ago

No idea, but we do.

ejholmes commented 6 years ago

Is there a reason to keep around old inactive locks?

No reason other than having an audit trail of who locked what, when.