remind101 / slashdeploy

GitHub Deployments for Slack
https://slashdeploy.io
BSD 2-Clause "Simplified" License
153 stars 20 forks source link

Add latest command #143

Closed xfontro closed 6 years ago

xfontro commented 6 years ago

This PR fixes #25 adding latest command. You can either pass it the environment you want to retrieve the latest deployment from or not:

/deploy latest REPO: I wasn't sure about which would be the desired behaviour on this case, so proposing this:

/deploy latest REPO to ENVIRONMENT: Returns the latest deployment for a concrete environment.

Added a few specs also. One of them is commented because seems like the behaviour on the fake github client is not the same as on Octokit client, you can check the comments on the specs.

russellballestrini commented 6 years ago

Wow thanks @xfontro - this looks really solid. Reviewing now.

xfontro commented 6 years ago

Thanks for the fast review guys! 🎉 🔝 Just added a few commits fixing the issues you mentioned

russellballestrini commented 6 years ago

@xfontro merged! Thanks again!