remind101 / slashdeploy

GitHub Deployments for Slack
https://slashdeploy.io
BSD 2-Clause "Simplified" License
153 stars 20 forks source link

allow swapping the environment and repo names in the lock and unlock commands #174

Closed emi-wheee closed 2 years ago

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
92.0% 92.0% Duplication

isobit commented 3 years ago

I like the idea of tolerating the reversal since grammatically it works either way, but I feel uncomfortable about making the slashdeploy command parsing even more ambiguous. This has the potential to be dangerous if someone were to have a repo with the same name as an environment.

emi-wheee commented 3 years ago

Would you feel better about just reversing the order of them and not allowing both? Honestly my main complaint is the inconsistency between deploy ("project on environment") and lock ("environment on project"); I did it this way because I figured a lot of people who have been using this longer than I have will have the backwards way committed to muscle memory by now.

aengelas commented 3 years ago

I'm +1 on @emi-wheee 's idea to just standardize the order.

jherico commented 3 years ago

why don't we make repositories of production and staging right now and just put readmes in them explaining they should never be used for apps and why.

Quality of life is king, and not having to remember argument order sparks joy.

aengelas commented 3 years ago

Or maybe even better, just use flags instead of positional arguments. then it's choose your ordering adventure

aengelas commented 2 years ago

Closing this since we're getting rid of slashdeploy.