search

remind101 / slashdeploy

GitHub Deployments for Slack
https://slashdeploy.io
BSD 2-Clause "Simplified" License
153 stars 20 forks source link

env should validate against whitelist #50

Closed turadg closed 6 years ago

turadg commented 8 years ago

/deploy lock fakeenv on repo is working. Would be nice if it didn't. :)

That may be rare. Another case is /deploy lock STAGING on repo, which is not the user's intended action. So another option is to just treat environments case-insensitive.

ejholmes commented 8 years ago

Yeah, I definitely agree. Long term would be for users to manage the list of environments through the web interface and have /deploy error out for unkown environments. Otherwise you end up with a bunch of typos in /deploy where :)