search

remind101 / slashdeploy

GitHub Deployments for Slack
https://slashdeploy.io
BSD 2-Clause "Simplified" License
153 stars 20 forks source link

Refine lock stealing. #51

Closed ejholmes closed 8 years ago

ejholmes commented 8 years ago

Closes https://github.com/ejholmes/slashdeploy/issues/49

This introduces the behavior suggested in https://github.com/ejholmes/slashdeploy/issues/49, so that stealing someone else's lock requires a !. This also means you can use the /deploy lock command to check if an environment is already locked by someone.

turadg commented 8 years ago

LGTM. I had a comment about giving feedback when it's already locked by you, but that's separate from #49.

atmos commented 8 years ago

Nice, I always implemented this as a task like /deploy:lock so the rest of the pattern was more consistent. At GitHub we just had /lock

ejholmes commented 8 years ago

@atmos nice. I really like the idea of doing something like /deploy:<task> and making locking just be a task. Any ideas how to do something like /deploy:<task> with Slack?

ejholmes commented 8 years ago

This has been running prod for a while. Merging.