Locks should always prevent auto deployments

remind101 / slashdeploy

GitHub Deployments for Slack

https://slashdeploy.io

BSD 2-Clause "Simplified" License

153 stars 20 forks source link

Locks should always prevent auto deployments #73

Closed ejholmes closed 7 years ago

ejholmes commented 8 years ago

Currently, locks only prevent deploying for anyone other than the locker. For auto deployments, the lock should prevent everything.

ejholmes commented 7 years ago

I don't know why I reported this, since this case is already tested for. Auto deployments fail when the environment is locked, regardless of the locker.

https://github.com/ejholmes/slashdeploy/commit/5b8d38e93a0a3320c416f6c1680211ba9d107182 added DM's for when the auto deployment fails because the environment is locked.