search

remind101 / slashdeploy

GitHub Deployments for Slack
https://slashdeploy.io
BSD 2-Clause "Simplified" License
153 stars 20 forks source link

Extend auto deployments to manually triggered deploys #95

Open ejholmes opened 7 years ago

ejholmes commented 7 years ago

If you try to /deploy something that has some pending commit statuses, you'll see a message like this:

I think it would be nice if the buttons were extended with an "Enqueue" button, which would queue it up to be deployed once the commit statuses were passing.

This could use all of the existing infrastructure for CD, so it'd be really easy to build.

ejholmes commented 7 years ago

One thing that isn't so straightforward with this is that, when you request a deployment through /deploy, you're usually giving a ref (branch/tag, eg. "master") and the GitHub deployments API does it's magic by converting that ref to a commit sha to deploy.

The AutoDeployments infrastructure with SlashDeploy only deals in commit sha's, so SlashDeploy itself would need to do some work to resolve a ref to a sha. Lame. It'd be nice if the error returned when creating a deployment gave you the resolved ref.