add generic resource creator

remind101 / stacker_blueprints

DEPRECATED - moved to:

https://github.com/cloudtools/stacker_blueprints

BSD 2-Clause "Simplified" License

39 stars 53 forks source link

add generic resource creator #122

Closed justinkillen closed 7 years ago

justinkillen commented 7 years ago

Example yaml:

name: generic-resource-volume class_path: blueprints.generic.GenericResourceCreator variables: Class: ec2.Volume Output: VolumeId Properties: VolumeType: gp2 Size: 5 Encrypted: true AvailabilityZone: us-east-1b

justinkillen commented 7 years ago

When I try to look at the CircleCI test failure, I just get a perpetual loading spinner - can somebody check this?

GarisonLotus commented 7 years ago

make test flake8 stacker_blueprints stacker_blueprints/generic.py:8:1: E302 expected 2 blank lines, found 1 stacker_blueprints/generic.py:35:80: E501 line too long (86 > 79 characters) make: *** [test] Error 1

Two simple fixes.

justinkillen commented 7 years ago

Updated - passing checks now

phobologic commented 7 years ago

Oh, one more thing - can you write a test for this? Trying to require them with all the new blueprints. You can see an example here:

https://github.com/remind101/stacker_blueprints/blob/master/tests/test_aws_lambda.py

Thanks!

phobologic commented 7 years ago

Also, just opened this: https://github.com/cloudtools/troposphere/pull/761

justinkillen commented 7 years ago

All requested changes satisfied