search

remind101 / stacker_blueprints

DEPRECATED - moved to:
https://github.com/cloudtools/stacker_blueprints
BSD 2-Clause "Simplified" License
39 stars 53 forks source link

Correctly test sqs.Queue parameters in sqs.py #131

Closed Lowercases closed 6 years ago

Lowercases commented 6 years ago

validate_parameters() has a fixed list of valid sqs.Queue parameters which is not in sync with troposphere.

Notably, it lacks QueueName, which makes it fail when using FifoQueue=True -- since FifoQueue requires a name set. QueueName should have been added in https://github.com/remind101/stacker_blueprints/pull/118 -- this merge solves that and also tries to prevent this type of error in the future by using the keys from sqs.Queue.props for checking instead of listing parameters.

Also add a test for sqs.py.

Lowercases commented 6 years ago

Superseded by https://github.com/remind101/stacker_blueprints/pull/132.